Hello, Thanks for the testing, done for 5.3 branch.
Cheers, Henning -- Henning Westerholt – https://skalatan.de/blog/ Kamailio services – https://gilawa.com<https://gilawa.com/> From: sr-users <[email protected]> On Behalf Of Sergiu Pojoga Sent: Thursday, April 23, 2020 9:14 PM To: Kamailio (SER) - Users Mailing List <[email protected]> Subject: Re: [SR-Users] nat_uac_test(8) Hi there, To finalize this matter, any chance this gets backported to stable branches now that the new nathelper nat_addr_mode modparam has been tested? Thanks. --Sergiu On Tue, Apr 7, 2020 at 11:52 AM Sergiu Pojoga <[email protected]<mailto:[email protected]>> wrote: Hi Daniel, Voilà: https://github.com/kamailio/kamailio/issues/2277 Thanks, --Sergiu On Tue, Apr 7, 2020 at 11:31 AM Daniel-Constantin Mierla <[email protected]<mailto:[email protected]>> wrote: Hello, better create a new issue, rather than adding comments to old merged PRs or closed issues, because they do not pop up in front on the web portal and likely the code has changed. In the new issue/PR, you can reference the old one if there are relevant details. Cheers, Daniel On 07.04.20 17:25, Sergiu Pojoga wrote: Hi, It's been a while, had the chance to notice only now a live case involving rfc7335 private IPs. It appears as though either nat_uac_test() or more likely fix_nated_sdp() doesn't catch the 192.0.0.0/29<http://192.0.0.0/29> subnet as private. Added a comment including sip dump example to the closed PR, if someone has the desire to look into it, https://github.com/kamailio/kamailio/pull/1488 Thanks, --Sergiu On Fri, Mar 23, 2018 at 7:30 AM Daniel Tryba <[email protected]<mailto:[email protected]>> wrote: On Fri, Mar 23, 2018 at 10:43:05AM +0100, Daniel Tryba wrote: > On Thu, Mar 22, 2018 at 04:23:18PM -0400, John Petrini wrote: > > If you're asking if nat_uac_test should be updated to check for > > 192.0.0.0/29<http://192.0.0.0/29> > > I think that's a great idea. ... > I'm to lazy^W^Wdon't have the time to figure out how to do the > appropriate git magic.S I lied: https://github.com/kamailio/kamailio/pull/1488 _______________________________________________ Kamailio (SER) - Users Mailing List [email protected]<mailto:[email protected]> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users _______________________________________________ Kamailio (SER) - Users Mailing List [email protected]<mailto:[email protected]> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users -- Daniel-Constantin Mierla -- www.asipto.com<http://www.asipto.com> www.twitter.com/miconda<http://www.twitter.com/miconda> -- www.linkedin.com/in/miconda<http://www.linkedin.com/in/miconda>
_______________________________________________ Kamailio (SER) - Users Mailing List [email protected] https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
