the bitrig master branch has been updated by pedro with 7 new commits: commit e7a7b07bf15f071cb65aaa7ad0555bf1be852512 diff: https://github.com/bitrig/bitrig/commit/e7a7b07 author: Pedro Martelletto <[email protected]> date: Fri Jan 30 10:25:18 2015 +0100
When loading a tmpfs snap, always cleanup upon failure. OK natano@. M sys/tmpfs/tmpfs_snapshot.c commit 41398c211c39f29a1bbc7f379193a30a6097282c diff: https://github.com/bitrig/bitrig/commit/41398c2 author: Pedro Martelletto <[email protected]> date: Fri Jan 30 10:18:44 2015 +0100 Ensure that tmpfs_snap_node_setsize() only happens once for a file. OK natano@. M sys/tmpfs/tmpfs_snapshot.c commit 8fa556254db43cf01d2bb1bedae5dc643770fe1c diff: https://github.com/bitrig/bitrig/commit/8fa5562 author: Pedro Martelletto <[email protected]> date: Fri Jan 30 10:10:30 2015 +0100 Don't call tmpfs_free_node() from tmpfs_snap_load_{hdr,file}(). As long as tmpfs_snap_load_cleanup() is called in the error path, the node will be disposed of accordingly. Pointed out by natano@. OK natano@. M sys/tmpfs/tmpfs_snapshot.c commit 1477b4062b52960a6da3d28c5312d63eae4457b9 diff: https://github.com/bitrig/bitrig/commit/1477b40 author: Pedro Martelletto <[email protected]> date: Wed Jan 28 11:39:07 2015 +0100 Correctly set the attributes of the root node when loading tmpfs snapshots. The permissions were left completely zero'd out, as noticed by Markus Friedl <[email protected]>. Set them according to the root node entry in the tmpfs snapshot image. Bump copyright and add a comment while here. OK natano@. M sys/tmpfs/tmpfs_snapshot.c M sys/tmpfs/tmpfs_subr.c commit 62b3162fdb1a26e453d8edc31b324cadce5879db diff: https://github.com/bitrig/bitrig/commit/62b3162 author: pedro martelletto <[email protected]> date: Sat Jan 24 17:02:16 2015 +0100 Simplify error handling. - Let tmpfs_snap_load_hdr() do tmpfs_free_node(). - Get rid of unnecessary goto's. - Fix a leak in tmpfs_snap_attach_node(). OK natano@. M sys/tmpfs/tmpfs_snapshot.c commit a35ba3c714610d20c5692ce43fe2cd9698f593c6 diff: https://github.com/bitrig/bitrig/commit/a35ba3c author: pedro martelletto <[email protected]> date: Sat Jan 24 16:56:20 2015 +0100 Handle error conditions gracefully in tmpfs_alloc_node(). Replace a few occurences of KASSERT() with checks followed by appropriate error handling. OK natano@. M sys/tmpfs/tmpfs_mem.c M sys/tmpfs/tmpfs_snapshot.c M sys/tmpfs/tmpfs_subr.c commit e7f3463f186d579a8c73629b53e0473efa8599e1 diff: https://github.com/bitrig/bitrig/commit/e7f3463 author: pedro martelletto <[email protected]> date: Sat Jan 24 16:40:50 2015 +0100 Initialise td_node in tmpfs_alloc_dirent(). If the allocation of a new node in tmpfs fails before td_node is set, tmpfs_free_dirent() will be called to dispose of the corresponding directory entry, and tmpfs_free_dirent() expects td_node to be NULL. Since these entries are retrieved from a pool without PR_ZERO, td_node needs to be explicitly set. OK natano@. M sys/tmpfs/tmpfs_subr.c
