the bitrig master branch has been updated by patrick with 3 new commits: commit 550daaf52e525f9c1d87ea594963253ea9e92235 diff: https://github.com/bitrig/bitrig/commit/550daaf author: Patrick Wildt <[email protected]> date: Mon Feb 9 10:33:16 2015 +0100
Fix tautological comparisons. ti_event_ring and ti_tx_ring are char arrays embedded in a struct. Thus, checking the pointer of those members will always evaluate to true. M sys/dev/ic/ti.c commit e7d832b626773d3f3e9349401d73f08e03672759 diff: https://github.com/bitrig/bitrig/commit/e7d832b author: Patrick Wildt <[email protected]> date: Mon Feb 9 10:30:21 2015 +0100 Fix tautological comparison in dsdt code. The pnpid member is a char[20] array in a struct. It's the second member of that struct. Comparing the pointer of pnpid is always not NULL. M sys/dev/acpi/dsdt.c commit 11aaf6b07d693d9774d24cd3df1c993f8d593c7d diff: https://github.com/bitrig/bitrig/commit/11aaf6b author: Patrick Wildt <[email protected]> date: Mon Feb 9 10:26:45 2015 +0100 Don't compare against the pointer, it will always be true. The blkno value should be increased every time we have a transfer that has at least one byte. This check was broken, as it compared the pointer to the len structure to zero, instead of actually comparing the cmd length value. That always evaluates to true. Fix this by comparing to the byte count value, which is set a few lines earlier into the cmd len struct. M sys/scsi/st.c
