-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 03/25/2010 01:35 PM, Sumit Bose wrote: > On Thu, Mar 25, 2010 at 10:17:00AM -0400, Stephen Gallagher wrote: > On 03/25/2010 09:56 AM, Sumit Bose wrote: >>>>> NACK. >>>> >>>>> Please consider the following two comments: >>>> >>>>> - can you call free(user_msg) just after do_pam_conversation() to avoid >>>>> to have >>>>> it two times? >>>>> - can you make buf in read_pipe_handler() a buf[MAX_CHILD_MSG_SIZE] or >>>>> put the read into a while loop to avoid the multiple memory allocation >>>>> for large messages? >>>> >>>>> Thanks. >>>> >>>>> bye, >>>>> Sumit >>>> > > New patch attached. Thanks for the review. > > >> ACK > >> bye, >> Sumit > >
Pushed to master and 1-1-0 - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkurwWYACgkQeiVVYja6o6Mn1gCfYGrKAM62Cnq4lHqk9oN1lxfp g3YAmwWSCkqolaNLSPPB0kD/ZKVbDEso =U56a -----END PGP SIGNATURE----- _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
