I saw two compilation warnings when reviewing the recent path_utils
patches. The first hunk is a parameter that is unused, but set, the
second was an implicit function declaration due to forgotten private
header include.
From dd7801e2b42ec5346c1d80aba25c536c2a18e64a Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhro...@redhat.com>
Date: Tue, 6 Mar 2012 18:18:33 +0100
Subject: [PATCH] INI: Silence compilation warnings

* Do not set ext_data parameter to NULL
* include a private header to avoid implicit declarations
---
 ini/ini_configobj.c |    1 -
 ini/ini_valueobj.c  |    1 +
 2 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/ini/ini_configobj.c b/ini/ini_configobj.c
index 
3e5dec4733a49d03e44185637592f0efdbe7db3c..f825b735d2c513d4a0d3af619673392186edfe52
 100644
--- a/ini/ini_configobj.c
+++ b/ini/ini_configobj.c
@@ -182,7 +182,6 @@ static int ini_copy_cb(struct collection_item *item,
 
     TRACE_FLOW_ENTRY();
 
-    ext_data = NULL;
     *skip = 0;
 
     /* Banary items are the values */
diff --git a/ini/ini_valueobj.c b/ini/ini_valueobj.c
index 
a90fa451468aecc6c04f4411675ab67613a59cbe..8c378accfd6279ce3372ae90edfb877c63fdf3c4
 100644
--- a/ini/ini_valueobj.c
+++ b/ini/ini_valueobj.c
@@ -28,6 +28,7 @@
 #include "ref_array.h"
 #include "ini_comment.h"
 #include "ini_defines.h"
+#include "ini_valueobj.h"
 #include "trace.h"
 
 struct value_obj {
-- 
1.7.7.6

_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel

Reply via email to