On Tue, 2012-03-06 at 14:37 -0500, Dmitri Pal wrote: > On 03/06/2012 12:31 PM, Jakub Hrozek wrote: > > I saw two compilation warnings when reviewing the recent path_utils > > patches. The first hunk is a parameter that is unused, but set, the > > second was an implicit function declaration due to forgotten private > > header include. > > > > _______________________________________________ > > sssd-devel mailing list > > sssd-devel@lists.fedorahosted.org > > https://fedorahosted.org/mailman/listinfo/sssd-devel > > I am curios about the first issue. What is the problem with it? > I usually do something with unused arguments because otherwise the > compiler gives a warning that variable is passed but not used in the > function. > Removing this assignment would to the best of my knowledge produce a > warning at least used to.
In general, we build with -Wno-unused-parameter because this warning is pretty much always just noise. The patch is acked and pushed to master, but please see my comments in the thread "Fate of ding-libs branches".
signature.asc
Description: This is a digitally signed message part
_______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
