-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 01/30/2013 08:05 AM, Pavel Březina wrote: > On 01/30/2013 01:20 PM, Jakub Hrozek wrote: >> On Wed, Jan 30, 2013 at 12:16:04PM +0100, Pavel Březina wrote: >>> On 01/30/2013 12:12 PM, Pavel Březina wrote: >>>> On 01/29/2013 03:55 PM, Pavel Březina wrote: >>>>> ccache: recreate ccache if it was deleted >>>>> >>>>> https://fedorahosted.org/sssd/ticket/1512 >>>> >>>> Self nack. >>>> >>>> The previous version would recreate the ccache everytime, >>>> because kr->old_ccname is in TYPE:RESIDUAL format. I switched >>>> to krb5_cc_resolve(). >>>> >>>> New patch is attached. >>> >>> One more self nack. I forgot to commit last change - move >>> comment to better place. >>> >> >> We discussed the patch with Pavel on IRC and thought it might be >> better to move the login to krb5_util to the check_existing >> functions. _______________________________________________ >> sssd-devel mailing list sssd-devel@lists.fedorahosted.org >> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel > > Patch is attached. > >
Minor correction: "does not exists" should be "does not exist". Otherwise, this looks good to me. No need to send for re-review, just fix it during push. I tested it by manually deleting /run/user/$UID/krb5cc and trying to log in. Without this patch, I get: (Wed Jan 30 08:42:51 2013) [[sssd[krb5_child[12399]]]] [create_ccache_in_dir] (0x0040): 495: [-1765328189][Credential cache directory /run/user/13041/krb5cc does not exist] After applying the patch, I can log in appropriately. Ack (with the above nitpick). -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlEJJLkACgkQeiVVYja6o6PksACfRJyje1avQM83jkIXwbm36wi6 6N0An0KyDk6K7xYnbnVNl4o+dQYrXnCv =qsH/ -----END PGP SIGNATURE----- _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
