-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Wed 30 Jan 2013 08:48:41 AM EST, Stephen Gallagher wrote:
> ********* *BEGIN ENCRYPTED or SIGNED PART* *********
>
> On 01/30/2013 08:05 AM, Pavel Březina wrote:
>> On 01/30/2013 01:20 PM, Jakub Hrozek wrote:
>>> On Wed, Jan 30, 2013 at 12:16:04PM +0100, Pavel Březina wrote:
>>>> On 01/30/2013 12:12 PM, Pavel Březina wrote:
>>>>> On 01/29/2013 03:55 PM, Pavel Březina wrote:
>>>>>> ccache: recreate ccache if it was deleted
>>>>>>
>>>>>> https://fedorahosted.org/sssd/ticket/1512
>>>>>
>>>>> Self nack.
>>>>>
>>>>> The previous version would recreate the ccache everytime,
>>>>> because kr->old_ccname is in TYPE:RESIDUAL format. I switched
>>>>> to krb5_cc_resolve().
>>>>>
>>>>> New patch is attached.
>>>>
>>>> One more self nack. I forgot to commit last change - move
>>>> comment to better place.
>>>>
>>>
>>> We discussed the patch with Pavel on IRC and thought it might be
>>> better to move the login to krb5_util to the check_existing
>>> functions. _______________________________________________
>>> sssd-devel mailing list sssd-devel@lists.fedorahosted.org
>>> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>>
>> Patch is attached.
>>
>>
>
> Minor correction:
> "does not exists" should be "does not exist".
>
> Otherwise, this looks good to me. No need to send for re-review, just
> fix it during push.
>
> I tested it by manually deleting /run/user/$UID/krb5cc and trying to
> log in. Without this patch, I get:
>
> (Wed Jan 30 08:42:51 2013) [[sssd[krb5_child[12399]]]]
> [create_ccache_in_dir] (0x0040): 495: [-1765328189][Credential cache
> directory /run/user/13041/krb5cc does not exist]
>
>
> After applying the patch, I can log in appropriately.
>
> Ack (with the above nitpick).
Since the original was already pushed, I pushed the attached minor
patch under the one-liner rule to both master and sssd-1-9.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlEJKS0ACgkQeiVVYja6o6P4EgCgoDQ7sqYB19za32hyIsk/yjEZ
2LAAn2ZcO0e0fseriVqfheRKz8p2H56j
=8NN5
-----END PGP SIGNATURE-----
>From 6669c0f5f686c5c9b8c843327c7895c7c16ad4a4 Mon Sep 17 00:00:00 2001
From: Stephen Gallagher <sgall...@redhat.com>
Date: Wed, 30 Jan 2013 08:52:27 -0500
Subject: [PATCH] Fix minor grammar error in log
---
src/providers/krb5/krb5_utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/providers/krb5/krb5_utils.c b/src/providers/krb5/krb5_utils.c
index 7b56be52497ae66fa536b76ca0561ec3cc3208ce..e71f6c4dfd1f5aa3c63da78b74a9b1c94419a369 100644
--- a/src/providers/krb5/krb5_utils.c
+++ b/src/providers/krb5/krb5_utils.c
@@ -773,7 +773,7 @@ cc_residual_is_used(uid_t uid, const char *ccname,
if (ret == -1) {
ret = errno;
if (ret == ENOENT) {
- DEBUG(SSSDBG_FUNC_DATA, ("Cache file [%s] does not exists, "
+ DEBUG(SSSDBG_FUNC_DATA, ("Cache file [%s] does not exist, "
"it will be recreated\n", ccname));
*result = false;
return EOK;
--
1.8.1
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
