On (14/03/14 12:18), Dmitri Pal wrote: >On 03/14/2014 10:59 AM, Lukas Slebodnik wrote: >>On (08/03/14 19:11), Dmitri Pal wrote: >>>Hello, >>> >>>The following patches address the request to be able to read config >>>data from a memory buffer rather than a file. >>>Ticket: https://fedorahosted.org/sssd/ticket/2267 >>> >>>It also addresses a build problem that I found on my system and fixes >>>a tight loop in parsing when we ignore errors and file is empty. >>> >>> >>>-- >>>Thank you, >>>Dmitri Pal >>> >>>Sr. Engineering Manager for IdM portfolio >>>Red Hat Inc. >>> >>> >>>------------------------------- >>>Looking to carve out IT costs? >>>www.redhat.com/carveoutcosts/ >>> >>> >>> >>> From 05229bcdedf90e81991c9f907c6acca93292a93b Mon Sep 17 00:00:00 2001 >>>From: Dmitri Pal<d...@redhat.com> >>>Date: Sat, 8 Mar 2014 18:59:20 -0500 >>>Subject: [PATCH 1/4] [BUILD] Fixing build >>> >>>The EXTRA_ prefix is not recognized by RHEL6 autotools. >>>--- >>>Makefile.am | 2 +- >>>1 files changed, 1 insertions(+), 1 deletions(-) >>> >>>diff --git a/Makefile.am b/Makefile.am >>>index 44a9dff..cb9008f 100644 >>>--- a/Makefile.am >>>+++ b/Makefile.am >>>@@ -256,7 +256,7 @@ libini_config_la_SOURCES = \ >>> ini/ini_get_array_valueobj.c \ >>> ini/ini_list_valueobj.c \ >>> trace/trace.h >>>-EXTRA_libini_config_la_DEPENDENCIES = ini/libini_config.sym >>>+libini_config_la_DEPENDENCIES = ini/libini_config.sym >>>libini_config_la_LIBADD = \ >>> libcollection.la \ >>> libpath_utils.la \ >>>-- >>>1.7.1 >>> >>NACK to this patch >> >>It breaks parallel build. Build in koji will fail as well. >> >>make -j4 V=0 >> >>//snip >> >> CC ini/ini_get_valueobj.lo >> CC ini/ini_get_array_valueobj.lo >> CC ini/ini_list_valueobj.lo >> CCLD libdhash.la >> CCLD libpath_utils.la >> CCLD libcollection.la >> CCLD libref_array.la >> CCLD libbasicobjects.la >> CCLD libini_config.la >>libtool: link: cannot find the library `libbasicobjects.la' or unhandled >>argument `libbasicobjects.la' >>make[1]: *** [libini_config.la] Error 1 >>make[1]: *** Waiting for unfinished jobs.... >>make[1]: Leaving directory `/ding-libs' >>make: *** [all] Error 2 >> >>We should use other solution proposed in mail >> >> https://lists.fedorahosted.org/pipermail/sssd-devel/2014-March/018758.html >> >>There are not any warnings from static analysers. >> >>I will do review of other patches later. >> >>LS >As we discussed you can ignore this patch. It fixes my build >environment so I will keep it private but I need because otherwise I >can't build anything. > This is not problem only with your dev environment. src.rpm from ding-libs master cannot be rebuilt for el6.
LS _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
