On 02/25/2015 11:14 AM, Jakub Hrozek wrote:
On Wed, Feb 25, 2015 at 09:51:24AM +0100, Lukas Slebodnik wrote:
On (25/02/15 08:33), Jakub Hrozek wrote:
On Tue, Feb 24, 2015 at 09:16:09PM +0100, Lukas Slebodnik wrote:
On (24/02/15 19:52), Jakub Hrozek wrote:
On Tue, Feb 24, 2015 at 05:52:26PM +0100, Lukas Slebodnik wrote:
On (24/02/15 16:55), Jakub Hrozek wrote:
Hi,
the attached two patches add a way to detect pre-1.0 cmocka and adds
compatible definitions in the first patch and uses them to convert a
single unit test.
I found the approach ugly myself, so much that I'm considering converting
all cmocka-based tests to cmocka-1.0 and don't compile the cmocka tests at
all unless 1.0 or later is present on the system. It's not functionality
after all, "just" tests and for CI we could add cmocka-1.0 to the CI
system ourselves..
Opinions?
+1 for patch.
Does +1 for the patch also mean -1 for the proposal to *only* support
cmocka-1.0 and later?
I already see deprecated warnings. cmocka 1.0 is in f21 updates-testing
Yes, btw Andreas would update libcmocka on all releases, including
private RHEL buildroots. So the "only" systems running pre-1.0 cmocka
would be non-RH distributions.
For instance Ubuntu contains 0.4..
cmocka is optional dependency but we try to run CI build on debian testing.
Debian testing (Jessie) is frozen since 2014-Oct-05. So we will need to wait
for next debian release to have cmocka-1.0 in (next) Debian testing)
If we agree we disable cmocka tests in our CI on debian
I'm fine with support *only* cmocka-1.0 and later.
I was proposing to build cmocka-1.0 from source on the Debian CI
machines.
I haven't seen this proposal yet :-)
IMHO, it's reasonable compromise.
If Nikolai agrees let's go with cmocka-1.0+ way
Does Nikolai agree? :-)
Sure :) It will do, as long as we support running CI without cmocka-1.0+, i.e.
without tests requiring it.
Nick
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
