On 06/05/2015 12:36 PM, Jakub Hrozek wrote:
[snip]
You're right and that was a really sloppy patch.
New patchset is attached.
Actually I'm happy to see that not just my patches need more passes to
be acked :-).
5th patch)
+static void sdap_inherit_user_options(char **inherit_opt_list,
+ struct sdap_attr_map
*parent_user_map,
+ struct sdap_attr_map
*child_user_map)
+{
+ int inherit_options[] = {
+ SDAP_AT_USER_PRINC,
+ SDAP_OPTS_USER /* sentinel */
+ };
+ int i;
+ int opt_index;
+ bool inherit_option;
+
+ for (i = 0; inherit_options[i] != SDAP_OPTS_USER; i++) {
+ opt_index = inherit_options[i];
+
+ inherit_option =
string_in_list(parent_user_map[opt_index].opt_name,
+ inherit_opt_list,
+ false);
+ if (inherit_option == false) {
+ continue;
+ }
+
+ sdap_copy_map_entry(parent_user_map,
+ child_user_map,
+ inherit_options[i]);
Before pushing you might 's/inherit_options[i]/opt_index/' to reuse
newly introduced variable but I don't really care.
+ }
+}
CI passed:
http://sssd-ci.duckdns.org/logs/job/16/81/summary.html
My testing passed. I found just one nitpick and I leave it to Jakub's
discretion how to handle it.
ACK
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
