On Thu, Jul 07, 2016 at 06:06:26PM +0200, Jakub Hrozek wrote:
> On Thu, Jul 07, 2016 at 01:05:39PM +0200, Lukas Slebodnik wrote:
> > On (05/07/16 07:59), Jakub Hrozek wrote:
> > >On Fri, Jul 01, 2016 at 08:45:53AM +0200, Lukas Slebodnik wrote:
> > >> ehlo,
> > >>
> > >> We usually inform about optional build dependencies at configure time
> > >> and which option can disable checking of this dependency.
> > >>
> > >> LS
> > >
> > >I agree with the intent, but I would just say we need such and such
> > >library, instead of a header file. This is also what we say when the
> > >samba libraries are not found.
> > Detection of http_parser and libjansson is slit into 3 parts.
> > a) try detect with pkg-config (http_parser doesn' have it)
> > b) detect header file
> > c) check for specific function if header file is available.
> > 
> > I modified error mesasge for the 2nd step.
> > Error message for library with wrong function is different.
> >   AC_MSG_ERROR([libhttp_parser missing http_parser_init])
> > I didn't change it because hint should be added
> > to the 2nd step and not the 3rd step.
> > 
> > I choose to inform about header file because the name of package
> > is not the same on all distributions
> >  (debian:libhttp-parser-dev fedora:http-parser-devel)
> > 
> > But feel free to propose better sentences.
> > 
> > LS
> 
> I really have issues replying to sssd-devel lately, maybe third time is
> the charm -- ACK, no point in arguing about error message in configure.

* master: c5a47e4a809aca39669e26d6136f8056952efd74
_______________________________________________
sssd-devel mailing list
[email protected]
https://lists.fedorahosted.org/admin/lists/[email protected]

Reply via email to