On 09/05/2016 10:23 AM, Lukas Slebodnik wrote:
On (05/09/16 15:54), Petr Cech wrote:
On 09/05/2016 09:45 AM, Lukas Slebodnik wrote:
On (02/09/16 15:34), Petr Cech wrote:
On 09/02/2016 03:31 PM, Justin Stephenson wrote:
On 09/02/2016 05:23 AM, Petr Cech wrote:
On 09/01/2016 03:36 PM, Justin Stephenson wrote:
On 08/30/2016 03:54 AM, Jakub Hrozek wrote:
On Sat, Aug 27, 2016 at 12:54:53PM -0400, Justin Stephenson wrote:
Hello,
The attached patches resolve https://fedorahosted.org/sssd/ticket/3142
However, I am having difficult with the man page addition to
'src/man/sssd.conf.5.xml' for this new option. I have stared at the
open and
close xml tags(for far too long) and it looks correct but when I
build sssd
I never see the sssd.conf man page inclusion. Could anyone tell me
what I am
missing here?
If you feel there is better wording for the description please let me
know.
Kind regards,
Justin Stephenson
From 0552c199dd37c7e280304b9bc92ff44a8a1a6d57 Mon Sep 17 00:00:00 2001
From: Justin Stephenson <jstep...@redhat.com>
Date: Fri, 26 Aug 2016 15:15:32 -0400
Subject: [PATCH 1/2] MONITOR: Remove --disable-netlink
command-line option
I'm not sure I like removing the netlink option w/o letting admins who
use it at least know what happened. Could we keep the option in the
popt
option list, but use the HIDDEN argument so that it doesn't show up in
--help output and print a loud warning that the option was removed in
favor of a sssd.conf option?
I already know of two people from sssd-users list who might be using
this feature. On the other hand, it was just introduced in the last
version and not in any enterprise distro, so just printing a warning
and
removing even that warning in the next version would be fine for me..
Agreed, please see updated patches also with Petr's corrections. Once
this fix is pushed I can respond to the email and at least let these
users know.
I am still having trouble with the man page addition to sssd.conf not
showing, any ideas why?
diff --git a/src/man/sssd.conf.5.xml b/src/man/sssd.conf.5.xml
index
ae291e0fc8f2f9afabcdf32f18a5ec12252bbbbf..6f231b8ab8fc078d83331bb7ef5b980528a30bd6
100644
--- a/src/man/sssd.conf.5.xml
+++ b/src/man/sssd.conf.5.xml
@@ -482,6 +482,24 @@
</para>
</listitem>
</varlistentry>
+ <varlistentry>
+ <term>disable_netlink (boolean)</term>
+ <listitem>
+ <para>
+ SSSD hooks into the netlink
interface to
+ monitor changes to routes, addresses,
links
+ and trigger certain actions.
+ </para>
+ <para>
+ The SSSD state changes caused by
netlink
+ events may be undesirable and can be
disabled
+ by setting this option to 'true'
+ </para>
+ <para>
+ Default: false (netlink changes are
detected)
+ </para>
+ </listitem>
+ </varlistentry>
</variablelist>
</para>
</refsect2>
Kind regards,
Justin Stephenson
From c52c0c1a520cdf8509baaaaac00fa3c7bec0dd73 Mon Sep 17 00:00:00 2001
From: Justin Stephenson <jstep...@redhat.com>
Date: Fri, 26 Aug 2016 17:43:25 -0400
Subject: [PATCH 2/2] MONITOR: Add disable_netlink option
LGTM, untested, though.
Hello Justin and Jakub,
I tested it:
sssd --help ... option is gone
/sbin/sssd --disable-netlink
Option --disable-netlink has been removed and replaced as a Monitor
option in sssd.conf
I see disable-netlink in man sssd.conf.
Justin, I run 'make rpms' and reinstall all,
so man pages were reinstall too.
Thanks Petr, I was using the steps in the Contribute wiki 'reconfig &&
chmake' then 'sssinstall' but I guess that did not update the man pages
from my commit as expected.
So far as I know, 'sssinstall' isn't good for man pages. But 'make rpms'
build whole all necessary things.
Could you elaborate?
Why 'sssinstall is not good for man pages?
LS
Hi Lukas,
if I understand correctly, command 'reconfig'
prepare build environment to no producing man pages.
See contrib/fedora/bashrc_sssd:53:
${SSSD_NO_MANPAGES-} \
So if someone run reconfig before sssinstall it will
not install recent man pages.
Or did I understand it wrong way?
I have no idea what is a purpose of "SSSD_NO_MANPAGES"
It is not used anywhere in sssd.
$ source contrib/fedora/bashrc_sssd
$ reconfig
$ chmake
$ make install DESTDIR=$PWD/_inst
$ find $PWD/_inst -type f | grep man |wc -l
30
ans sssinstall does not do any magic with man pages.
sssinstall()
{
sudo make -j$PROCESSORS install \
&& sudo rm -f $SSS_LIBDIR/ldb/modules/ldb/memberof.la \
&& sudo restorecon -v /$SSS_LIB/libnss_sss.so.2 \
/$SSS_LIB/security/pam_sss.so
}
Summary:
man pages should be properly installed with sssinstall
If no please file a bug.
I noticed the man pages were updated correctly with 'sssinstall' on
previous patches I worked on, but for some reason it did not when I was
adding the sssd.conf.5.xml for this ticket.
I will file a bug if it happens again, perhaps I was just doing
something incorrectly in this instance.
Anyway, thanks for the review of these patches.
Kind regards,
Justin Stephenson
LS
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
