[SSSD] [sssd PR#65][synchronized] Fixing of nitpicks

[celestian]

   URL: https://github.com/SSSD/sssd/pull/65
Author: celestian
 Title: #65: Fixing of nitpicks
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/65/head:pr65
git checkout pr65

From 714c0b000c7c4197644ba11fd0ba8e64a6262c9f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20=C4=8Cech?= <pc...@redhat.com>
Date: Mon, 24 Oct 2016 16:14:58 +0200
Subject: [PATCH 1/2] RESPONDER: Adding of return value checking

---
 src/responder/common/data_provider/rdp_message.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/responder/common/data_provider/rdp_message.c b/src/responder/common/data_provider/rdp_message.c
index 6ad2ba0..22127ac 100644
--- a/src/responder/common/data_provider/rdp_message.c
+++ b/src/responder/common/data_provider/rdp_message.c
@@ -269,7 +269,7 @@ static void rdp_message_send_and_reply_done(DBusPendingCall *pending,
     sbus_req = talloc_get_type(ptr, struct sbus_request);
 
     ret = rdp_process_pending_call(sbus_req, pending, &reply);
-    if (reply == NULL) {
+    if (ret != EOK) {
         /* Something bad happened. Just kill the request. */
         ret = EIO;
         goto done;

From 27282131f3cad3284b5d3dec2b6f183668b43adf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20=C4=8Cech?= <pc...@redhat.com>
Date: Mon, 24 Oct 2016 16:20:22 +0200
Subject: [PATCH 2/2] UTIL: Removing of never read value

---
 src/util/sss_krb5.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/util/sss_krb5.c b/src/util/sss_krb5.c
index 2d2dfc4..4808a77 100644
--- a/src/util/sss_krb5.c
+++ b/src/util/sss_krb5.c
@@ -1104,7 +1104,6 @@ bool sss_krb5_realm_has_proxy(const char *realm)
 
     kerr = profile_get_values(profile, profile_path, &list);
     if (kerr == PROF_NO_RELATION || kerr == PROF_NO_SECTION) {
-        kerr = 0;
         goto done;
     } else if (kerr != 0) {
         DEBUG(SSSDBG_OP_FAILURE, "profile_get_values failed.\n");

_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org