URL: https://github.com/SSSD/sssd/pull/94
Title: #94: Enable {socket,dbus}-activation for responders
pbrezina commented:
"""
```c
if (conn->last_request_time != NULL) {
time_t *last_request_time = conn->last_request_time;
*last_request_time = time(NULL);
}
```
This looks weird. Why did you not use simply `conn->last_request_time =
time(NULL)`?
Otherwise the code looks good. I'm glad you got rid of those function pointers,
especially in `sbus` code. I need to do some testing before final ack but I
think we got there. Good job.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/94#issuecomment-273768810
_______________________________________________
sssd-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
