URL: https://github.com/SSSD/sssd/pull/94
Title: #94: Enable {socket,dbus}-activation for responders
pbrezina commented:
"""
> > if (conn->last_request_time != NULL) {
> > time_t *last_request_time = conn->last_request_time;
> >
> > *last_request_time = time(NULL);
> > }
> >
> > This looks weird. Why did you not use simply conn->last_request_time =
> > time(NULL)?
> >
> Hmmm. Got reminded the reason ... :-)
> Take a look on the conn structure and you'll realize that last_request_time
> is not a time_t, but a time_t *.
I meant: `*conn->last_request_time = time(NULL)` but it's my personal
preference, feel free to leave it this way.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/94#issuecomment-274467906
_______________________________________________
sssd-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
