URL: https://github.com/SSSD/sssd/pull/235 Title: #235: Allow using the "shortnames" feature without requiring any configuration from the client side
fidencio commented: """ On Tue, Apr 18, 2017 at 11:33 AM, lslebodn <[email protected]> wrote: > Removing unit test is not acceptable without writing new one. > Lukáš, Maybe I wasn't clear enough in the "NSS/TESTS: Improve non-fqnames tests" commit message. I do NOT remove any test per si. The situation before was: - I was using the very same setup() function and setting subdomain->fqnames = false in the tests that I've copied and pasted. The current situation is: - Now I set subdomain->fqnames = false in the newly introduced setup() function, which allows me to use the tests from where I copied, pasted and changed the code to set subdomain->fqnames = false. In the end, some code ended up removing which allowed me to use the previous tests and remove the tests that were introduced with the first part of these patches (but with a new setup() function). So, looking carefully at the patch and the commit message you'll realize that no tests were removed after all. Does that make sense to you? I'm removing the "Changes requested" label. > — > > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/SSSD/sssd/pull/235#issuecomment-294746901>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AAG4eoGAUeGYQ-X07sZAaM3whYj7Mkbgks5rxIN8gaJpZM4M7MHV> > . > """ See the full comment at https://github.com/SSSD/sssd/pull/235#issuecomment-294778275
_______________________________________________ sssd-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
