URL: https://github.com/SSSD/sssd/pull/235
Title: #235: Allow using the "shortnames" feature without requiring any
configuration from the client side
fidencio commented:
"""
@pbrezina: Yeah, not so easy to make the bad habits to go away :-)
Here's a diff of the changes made after your review:
```
[ffidenci@pessoa x86_64]$ git diff
diff --git a/src/responder/common/cache_req/cache_req_domain.c
b/src/responder/common/cache_req/cache_req_domain.c
index 21a4224..86a88ef 100644
--- a/src/responder/common/cache_req/cache_req_domain.c
+++ b/src/responder/common/cache_req/cache_req_domain.c
@@ -128,11 +128,10 @@ cache_req_domain_new_list_from_domain_resolution_order(
struct cache_req_domain **_cr_domains)
{
TALLOC_CTX *tmp_ctx;
+ struct cache_req_domain *cr_domains;
char **list = NULL;
errno_t ret;
- *_cr_domains = NULL;
-
tmp_ctx = talloc_new(NULL);
if (tmp_ctx == NULL) {
return ENOMEM;
@@ -151,9 +150,9 @@ cache_req_domain_new_list_from_domain_resolution_order(
}
}
- *_cr_domains = cache_req_domain_new_list_from_string_list(mem_ctx, domains,
- list);
- if (*_cr_domains == NULL) {
+ cr_domains = cache_req_domain_new_list_from_string_list(mem_ctx, domains,
+ list);
+ if (cr_domains == NULL) {
ret = ENOMEM;
DEBUG(SSSDBG_OP_FAILURE,
"cache_req_domain_new_list_from_domain_resolution_order() "
@@ -162,6 +161,7 @@ cache_req_domain_new_list_from_domain_resolution_order(
goto done;
}
+ *_cr_domains = cr_domains;
ret = EOK;
done:
```
"""
See the full comment at
https://github.com/SSSD/sssd/pull/235#issuecomment-296159240
_______________________________________________
sssd-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
