URL: https://github.com/SSSD/sssd/pull/259 Title: #259: RESPONDER: Also populate cr_domains when initializing the responders
pbrezina commented: """ I believe this code works. You just don't want to use `tevent_req_post` from other place then `_send` since it can be use only in a context where we don't issue any asynchronous request. So remove it from `cache_req_get_domains_done`. I'm also quite tentative to this patch. I think a better, cleaner solution would be to polish how often we issue getdomains request (it should be hours/minutes not seconds, since it rarely changes) and call it unconditionally from `cache_req_send`. So it looks like: `cache_req_send` -> get domains -> get domains done -> the stuff that is now in `cache_req_send` But we can do this in next version if you think it's too big functional change. """ See the full comment at https://github.com/SSSD/sssd/pull/259#issuecomment-299140303
_______________________________________________ sssd-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
