URL: https://github.com/SSSD/sssd/pull/259
Title: #259: RESPONDER: Also populate cr_domains when initializing the
responders
pbrezina commented:
"""
`cache_req_update_domains()` can be removed. There is no point for having
function for this. Also I think it will be good if you convert
`cache_req_process_input` into a separate request that will return username and
domain name. I.e.
```c
static tevent_req *
cache_req_input_send(TALLOC_CTX *mem_ctx,
struct cache_req *cr,
const char *domain)
^^^ This will call either get domains or sss_parse_inp_send.
static void cache_req_input_domains_done()
static void cache_req_input_parsed_done()
static errno_t
cache_req_input_recv(TALLOC_CTX *mem_ctx,
const char **_username,
const char **_domname)
^^^ This will return either original values
(input didn't need to be parsed) or parsed values.
```
`ret = sss_parse_inp_recv(subreq, state, &name, &domain)` will then become
`cache_req_input_recv`;
"""
See the full comment at
https://github.com/SSSD/sssd/pull/259#issuecomment-299440193
_______________________________________________
sssd-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
