URL: https://github.com/SSSD/sssd/pull/272
Author: lslebodn
Title: #272: cache_req: Fix warning maybe-uninitialized
Action: opened
PR body:
"""
the variable `req` could be used uninitialized in done section if talloc_new
returns `NULL`
src/responder/common/cache_req/cache_req_search.c:
In function 'cache_req_search_done':
src/responder/common/cache_req/cache_req_search.c:467:9:
error: 'req' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
tevent_req_error(req, ret);
^
src/responder/common/cache_req/cache_req_search.c:424:24:
note: 'req' was declared here
struct tevent_req *req;
^
cc1: all warnings being treated as errors
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/272/head:pr272
git checkout pr272
From e24e16233275fbf9d6d8ee8b0fd22e1fc059cbd7 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <[email protected]>
Date: Mon, 15 May 2017 10:25:39 +0200
Subject: [PATCH] cache_req: Fix warning maybe-uninitialized
src/responder/common/cache_req/cache_req_search.c:
In function 'cache_req_search_done':
src/responder/common/cache_req/cache_req_search.c:467:9:
error: 'req' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
tevent_req_error(req, ret);
^
src/responder/common/cache_req/cache_req_search.c:424:24:
note: 'req' was declared here
struct tevent_req *req;
^
cc1: all warnings being treated as errors
---
src/responder/common/cache_req/cache_req_search.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/responder/common/cache_req/cache_req_search.c b/src/responder/common/cache_req/cache_req_search.c
index 793dbc5..f6ef8cf 100644
--- a/src/responder/common/cache_req/cache_req_search.c
+++ b/src/responder/common/cache_req/cache_req_search.c
@@ -421,7 +421,7 @@ static void cache_req_search_done(struct tevent_req *subreq)
{
TALLOC_CTX *tmp_ctx;
struct cache_req_search_state *state;
- struct tevent_req *req;
+ struct tevent_req *req = NULL;
struct ldb_result *result = NULL;
errno_t ret;
_______________________________________________
sssd-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
