URL: https://github.com/SSSD/sssd/pull/272
Title: #272: cache_req: Fix warning maybe-uninitialized

lslebodn commented:
"""
> While this patch will certainly fix the compiler warning I wonder if it 
> wouldn't be better to call talloc_new() after req is set in 'req = 
> tevent_req_callback_data(subreq, struct tevent_req);'. This way 
> talloc_req_error() is called with a proper req instead of NULL?

Agree and there is already PR with such solution #273.
Closing this one
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/272#issuecomment-301434874
_______________________________________________
sssd-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to