URL: https://github.com/SSSD/sssd/pull/259 Title: #259: RESPONDER: Also populate cr_domains when initializing the responders
fidencio commented: """ So, I've changed the patch according to @sumit-bose's comments but not according to @pbrezina's comments (at least not yet). @pbrezina: I've failed miserably to understand how the suggested change would make this patch/code cleaner/simpler than how it is right now. If you don't mind, I'd prefer going through your suggestion (and actually having a different "module" as in a new cache_req_input.c file dealing with input in the way suggested by you when actually solving issue 3390). Does it make sense for you? Is it okay for you? @sumit-bose: I don't have a testing environment handy here, but there's on functional changes in the patch apart from the one suggested by yourself. Please, let me know if everything works as expected. For both of you, I've decided to not mix those 2 if conditions where we don't want to parse the input name in 1 because, IMO, the way it is right now is cleaner for whoever will have to deal with this code in the future (probably myself). """ See the full comment at https://github.com/SSSD/sssd/pull/259#issuecomment-301913549
_______________________________________________ sssd-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
