URL: https://github.com/SSSD/sssd/pull/481 Title: #481: gcc warnings: Getting rid of -Wsuggest-attribute=noreturn
jhrozek commented: """ I'm also a bit torn about one thing - are we OK with adding the attribute unconditionally or should we detect whether the system supports it and do something like we do with `HAVE_FUNCTION_ATTRIBUTE_DESTRUCTOR` or `SSS_ATTRIBUTE_WARN_UNUSED_RESULT`? Note that even we are not consistent in the current tree, some attributes like `__attribute__((always_inline))` or ` __attribute__((__sentinel__))` are used undonditionally, some are used conditionally. FWIW, I'm OK with SSSD using these attributes unconditionally, because both GCC and clang support them. """ See the full comment at https://github.com/SSSD/sssd/pull/481#issuecomment-352686410
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
