URL: https://github.com/SSSD/sssd/pull/475 Title: #475: LDAP: Only add a sdap_domain instance for the current domain when instantiating a new ad_id_ctx
jhrozek commented: """ Umm OK, right what I wrote the previous wall of text, I realized the patch might have been wrong. But at the same time. I was initially going to say that a single `sdap_opts` can only ever contain a single `sdap_domain` for "self", but looking at e.g. `sdap_ad_check_domain_local_groups()` or ` ad_get_dom_ldap_conn()` it looks like all domains should be represented by `sdap_domain` so that we can reach `ad_id_ctx` of another domain..correct? @sumit-bose do you maybe remember? If that's the case, then the right way to solve this would be to call `sdap_domain_get()` instead of dereferencing the `opts->sdom`.. We should really get this documented one way or another.. (and we have a ticket but..time..) """ See the full comment at https://github.com/SSSD/sssd/pull/475#issuecomment-358120530
_______________________________________________ sssd-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
