URL: https://github.com/SSSD/sssd/pull/5262 Title: #5262: DN with white spaces
sumit-bose commented: """ > > > @sumit-bose I see one more issue in the old code. If DN comes with escape > > > characters the we escape them again and we get > > > ``` > > > cn=Doe\, John => cn=Doe\5c\2c John > > > ``` > > > > > > > > > and it breaks the search. Lets address this too before merge. > > > > > > Hi, > > can you add such examples to the test as well to make sure we handle > > escaped characters, especially escaped spaces, correctly? > > bye, > > Sumit > > Unfortunately this issue is not addressed by this PR. Simple solution with > skipping escapes doesn't work and breaks the cache (Or at least tests). > > Considering that this is a bit different issue, I will address that > separately in other PR. Yes, makes sense, as we discussed, this is an issue which would already happen in the old code using just `sss_filter_sanitize()` so it can be handled separately. """ See the full comment at https://github.com/SSSD/sssd/pull/5262#issuecomment-675452160
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
