URL: https://github.com/SSSD/sssd/pull/5262 Title: #5262: DN with white spaces
sumit-bose commented: """ Hi, in general I agree with the patches. I'm just wondering if the changes are needed in places where the DN was generated by `ldb_dn_get_linearized()` which are the changes in - src/ldb_modules/memberof.c - src/providers/ldap/ldap_id_cleanup.c I wouldn't expect `ldb_dn_get_linearized()` to return extra space and so we can safe the extra check and keep `sss_filter_sanitize()`. While the cleanup would not matter much, the memberof plugin is often called and saving processing time would be beneficial. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pull/5262#issuecomment-675459244
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
