URL: https://github.com/SSSD/sssd/pull/5585
Title: #5585: Poor man's backtrace.

pbrezina commented:
"""
Can we make it work also with other logger than files? If there is a reason why 
only files is supported, please include a comment in the commit message.

Why do you use underscore before function names? I'm not completely against it, 
but it is not something that is common for SSSD.

IIRC we also talked about making the backtrace size and trigger level 
configurable, did you omit it on purpose?

Please, write the release note as a release note and not as a commit 
description (don't dive into technical details and make it understandable by 
normal users), e.g. "If `debug_backtrace_enabled` is set to true, all debug 
messages are printed to the logs when an error is detected even if 
`debug_level` is set to low values." Or something like that.


"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5585#issuecomment-829114268
_______________________________________________
sssd-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to