URL: https://github.com/SSSD/sssd/pull/5585 Title: #5585: Poor man's backtrace.
pbrezina commented: """ > > Can we make it work also with other logger than files? > > * `stderr`: I think it's not required at all to support feature for > `stderr` logger. As buffer is quite large, it would be very inconvenient to > get it in console. > > * `journal`: that's the question. I'm not sure that users who setup > journal as a logger for sssd (probably with very low debug level) want to > receive storm of messages (or huge packet) in case of error. Probably we will > add this later (maybe feature will be disabled by default for journal). But I > would really like to get some feedback first (for logger=files). > > > > If there is a reason why only files is supported, please include a comment > > in the commit message. > > Ok. > > > Why do you use underscore before function names? I'm not completely against > > it, but it is not something that is common for SSSD. > > This is my way to indicate "private" (local/static to this module) functions > (and `sss_debug_backtrace_` prefix for "public" functions) > I could also use `s_` prefix but I don't think you would like it more :) > FWIW, I don't recall anything relevant in "coding style"... Ok. > > IIRC we also talked about making the backtrace size and trigger level > > configurable, did you omit it on purpose? > > Yes, I decided to keep it simple in a first version. Ok. > I have a feeling this will only be useful in a totally "default" > configuration. > I guess users that consciously change debug related options in sssd.conf most > probably want specific verbosity as a generic log. Maybe there are some use > cases... But again, I'd like to have some feedback (or bug reports) first, > before complicating feature. The use case is to get more debug lines if needed for errors that happen only sporadicaly and customers needs to run sssd for a long time. Having a large debug level set is inconvenient for such situation. But we can add it later. > > Please, write the release note as a release note and not as a commit > > description (don't dive into technical details and make it understandable > > by normal users), e.g. "If `debug_backtrace_enabled` is set to true, all > > debug messages are printed to the logs when an error is detected even if > > `debug_level` is set to low values." Or something like that. > > Ok. > > Thanks for review. """ See the full comment at https://github.com/SSSD/sssd/pull/5585#issuecomment-829204089
_______________________________________________ sssd-devel mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/[email protected] Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
