URL: https://github.com/SSSD/sssd/pull/5910
Author: alexey-tikhonov
Title: #5910: SPEC: avoid weak dependencies
Action: opened
PR body:
"""
Require packages if really needed, suggest otherwise.
This is related to https://bugzilla.redhat.com/show_bug.cgi?id=1947918
I'm not sure what to do with:
```
Recommends: bind-utils
Recommends: adcli
```
`bind-utils` provides `nsupdate` used by IPA and AD backends, but SSSD can work
without it. And `adcli` is used by AD backend to renew machine password.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5910/head:pr5910
git checkout pr5910
From 3dd864c23adc9b274525935d98a64ce8745cb81e Mon Sep 17 00:00:00 2001
From: Alexey Tikhonov <atikh...@redhat.com>
Date: Mon, 6 Dec 2021 22:54:39 +0100
Subject: [PATCH] SPEC: avoid weak dependencies
Require packages if really needed, suggest otherwise.
---
contrib/sssd.spec.in | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/contrib/sssd.spec.in b/contrib/sssd.spec.in
index 7f75b1b5a3..f548b05fed 100644
--- a/contrib/sssd.spec.in
+++ b/contrib/sssd.spec.in
@@ -64,8 +64,8 @@ Requires: sssd-common = %{version}-%{release}
Requires: sssd-ipa = %{version}-%{release}
Requires: sssd-krb5 = %{version}-%{release}
Requires: sssd-ldap = %{version}-%{release}
-Recommends: sssd-proxy = %{version}-%{release}
-Recommends: logrotate
+Suggests: sssd-proxy = %{version}-%{release}
+Suggests: logrotate
Suggests: python3-sssdconfig = %{version}-%{release}
Suggests: sssd-dbus = %{version}-%{release}
@@ -166,9 +166,9 @@ License: GPLv3+
# due to ABI changes in 1.1.30/1.2.0
Requires: libldb >= %{ldb_version}
Requires: sssd-client%{?_isa} = %{version}-%{release}
-Recommends: libsss_sudo = %{version}-%{release}
-Recommends: libsss_autofs%{?_isa} = %{version}-%{release}
-Recommends: sssd-nfs-idmap = %{version}-%{release}
+Requires: (libsss_sudo = %{version}-%{release} if sudo)
+Requires: (libsss_autofs%{?_isa} = %{version}-%{release} if autofs)
+Requires: (sssd-nfs-idmap = %{version}-%{release} if libnfsidmap)
Requires: libsss_idmap = %{version}-%{release}
Requires: libsss_certmap = %{version}-%{release}
%if 0%{?rhel}
@@ -224,7 +224,7 @@ Requires: libsss_certmap = %{version}-%{release}
# required by sss_analyze
Requires: python3-systemd
Requires: python3-click
-Recommends: sssd-dbus
+Suggests: sssd-dbus
%description tools
Provides several administrative tools:
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
