URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements
justin-stephenson commented: """ Latest push addresses final items requested by Pavel: * splits a commit for [adding chain_id](https://github.com/SSSD/sssd/pull/5863/commits/bc5f885dcab2d6e61863bcc5fdc4ee2c3867f063) * removed cache req workaround and added commit https://github.com/SSSD/sssd/pull/5863/commits/a671dc01e219c6004ca24faab50a0c0f14580db8 (proper fix) This introduced an issue where `[ldb]` messages are tagged with CID/RID, which makes the log analyzer output quite unfriendly/ugly. ~~~ (2021-12-13 15:35:32): [be[redhat.com]] [sdap_save_user] (0x0400): [RID#4] Storing info for user jstep...@redhat.com (2021-12-13 15:35:32): [be[redhat.com]] [ldb] (0x10000): [RID#4] start ldb transaction (nesting: 1) (2021-12-13 15:35:32): [be[redhat.com]] [ldb] (0x10000): [RID#4] Added timed event "ldb_kv_callback": 0x1895110 (2021-12-13 15:35:32): [be[redhat.com]] [ldb] (0x10000): [RID#4] Added timed event "ldb_kv_timeout": 0x18a79c0 (2021-12-13 15:35:32): [be[redhat.com]] [ldb] (0x10000): [RID#4] Running timer event 0x1895110 "ldb_kv_callback" (2021-12-13 15:35:32): [be[redhat.com]] [ldb] (0x10000): [RID#4] Destroying timer event 0x18a79c0 "ldb_kv_timeout" (2021-12-13 15:35:32): [be[redhat.com]] [ldb] (0x10000): [RID#4] Destroying timer event 0x1895110 "ldb_kv_callback" (2021-12-13 15:35:32): [be[redhat.com]] [sysdb_search_by_name] (0x0400): [RID#4] No such entry (2021-12-13 15:35:32): [be[redhat.com]] [sysdb_store_user] (0x1000): [RID#4] User jstep...@redhat.com does not exist. ~~~ It could be addressed with the following diff, some other way in the ldb code, or these logs can be simply filtered out in the analyzer code. What do you suggest @alexey-tikhonov @sumit-bose ? ~~~ diff --git a/src/util/debug.c b/src/util/debug.c index b54eca7ce..33d6ea049 100644 --- a/src/util/debug.c +++ b/src/util/debug.c @@ -354,7 +354,9 @@ void sss_vdebug_fn(const char *file, debug_prg_name, function, level); if (debug_chain_id > 0) { - sss_debug_backtrace_printf(level, debug_chain_id_fmt, debug_chain_id); + if (strcmp(function, "ldb") != 0) { + sss_debug_backtrace_printf(level, debug_chain_id_fmt, debug_chain_id); + } } sss_debug_backtrace_vprintf(level, format, ap); ~~~ """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-992881236
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
