2.6.35-longterm review patch. If anyone has any objections, please let me know.
------------------ From: Samuel Ortiz <[email protected]> commit 37f9fc452d138dfc4da2ee1ce5ae85094efc3606 upstream. While parsing the GetValuebyClass command frame, we could potentially write passed the skb->data pointer. Reported-by: Ilja Van Sprundel <[email protected]> Signed-off-by: Samuel Ortiz <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: Andi Kleen <[email protected]> --- net/irda/iriap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: linux/net/irda/iriap.c =================================================================== --- linux.orig/net/irda/iriap.c +++ linux/net/irda/iriap.c @@ -502,7 +502,8 @@ static void iriap_getvaluebyclass_confir IRDA_DEBUG(4, "%s(), strlen=%d\n", __func__, value_len); /* Make sure the string is null-terminated */ - fp[n+value_len] = 0x00; + if (n + value_len < skb->len) + fp[n + value_len] = 0x00; IRDA_DEBUG(4, "Got string %s\n", fp+n); /* Will truncate to IAS_MAX_STRING bytes */ _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
