On Mon, Dec 20, 2010 at 03:49:39PM -0800, Greg KH wrote: > On Wed, Dec 08, 2010 at 10:42:43AM -0600, Robin Holt wrote: > > On Wed, Dec 08, 2010 at 08:37:58AM -0800, Greg KH wrote: > > > On Wed, Dec 08, 2010 at 09:02:25AM -0600, Robin Holt wrote: > > > > On Tue, Dec 07, 2010 at 03:23:46PM -0800, Greg KH wrote: > > > > > Robin, the patch below breaks the build on the .36 kernel tree with > > > > > the > > > > > following errors: > > > > > CC [M] drivers/misc/sgi-xp/xp_uv.o > > > > > drivers/misc/sgi-xp/xp_uv.c: In function ‘xp_remote_mmr_read’: > > > > > drivers/misc/sgi-xp/xp_uv.c:40:2: error: implicit declaration > > > > > of function ‘uv_gpa_to_soc_phys_ram’ > > > > > drivers/misc/sgi-xp/xp_uv.c:42:2: error: implicit declaration > > > > > of function ‘uv_gpa_in_mmr_space’ > > > > > drivers/misc/sgi-xp/xp_uv.c:45:2: error: implicit declaration > > > > > of function ‘gru_read_gpa’ > > > > > > > > > > Was there some other patch that I needed to apply to get this one to > > > > > work properly? > > > > > > > > I am sorry for this. I was embarrased when I saw the commit log. > > > > There were two minor patches immediately before c2c9f1 which needed to > > > > be applied as well. > > > > > > > > c2c9f115741453715d6b4da1cd2de65af8c7ad86 x86: uv: update XPC to handle > > > > updated BIOS interface > > > > 289750d1f1fd4a715baa2a2c6dd0cec2b8317fd7 X86: uv: implement a > > > > gru_read_gpa kernel function > > > > fae419f2abd15ab7d1cd1413e6683a276a4e14e2 x86: uv: introduce > > > > uv_gpa_is_mmr > > > > > > So those should be applied in backward order? > > > > Those are in the order from git log, so yes, please. > > > > > If so, I'll get to that for the next .32 release after this one, it's > > > big enough as it is already :) > > > > That is wonderful. > > All queued up now, and the build isn't broken!
I spoke too soon :( CC [M] drivers/misc/sgi-xp/xp_uv.o drivers/misc/sgi-xp/xp_uv.c: In function ‘xp_remote_mmr_read’: drivers/misc/sgi-xp/xp_uv.c:40:2: error: implicit declaration of function ‘uv_gpa_to_soc_phys_ram’ make[3]: *** [drivers/misc/sgi-xp/xp_uv.o] Error 1 So, I'll drop all three of these (note, I had to apply the first one above by hand, as it didn't apply properly), and I'll wait for you to send me tested, backported patches for the .32 tree. thanks, greg k-h _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
