Greg, if I send you a patch with an extra note in the commit message
that it has been adjusted for 2.6.32, there is usually a good reason for
that.  If you require explanation, please ask for it rather than quietly
substituting your own version.

Commit 7e8e5d9718744b817bfea6f020586d7035cc89f4 'netxen: module firmware
hints' added a MODULE_FIRMWARE reference to the 'unified' firmware files
for this driver, which the version in 2.6.32 does not support.  For a
similar reason, it doesn't apply cleanly.  In the version I sent to you
for 2.6.32.y, I fixed this up and noted that I had adjusted the patch.
But 2.6.32.40 includes a different version, where you have made a trivial
(and wrong) textual adjustment without even mentioning it in the commit
message.

I think the effect in this case is minor, but now I have to worry whether
you are quietly changing other patches.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
stable mailing list
[email protected]
http://linux.kernel.org/mailman/listinfo/stable

Reply via email to