2.6.32-longterm review patch. If anyone has any objections, please let us know.
------------------ From: Matvejchikov Ilya <[email protected]> commit 057bef938896e6266ae24ec4266d24792d27c29a upstream. TTY layer expects 0 if the ldisc->open operation succeeded. Signed-off-by : Matvejchikov Ilya <[email protected]> Acked-by: Oliver Hartkopp <[email protected]> Acked-by: Alan Cox <[email protected]> Signed-off-by: David S. Miller <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> --- drivers/net/slip.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/net/slip.c +++ b/drivers/net/slip.c @@ -850,7 +850,9 @@ static int slip_open(struct tty_struct * /* Done. We have linked the TTY line to a channel. */ rtnl_unlock(); tty->receive_room = 65536; /* We don't flow control */ - return sl->dev->base_addr; + + /* TTY layer expects 0 on success */ + return 0; err_free_bufs: sl_free_bufs(sl); _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
