On 02/24/2012 04:41 AM, Greg KH wrote: > On Thu, Feb 16, 2012 at 02:27:33PM +0530, Srivatsa S. Bhat wrote: >> [ Upstream commits: >> >> a144c6a6c924aa1da04dd77fb84b89927354fdff >> caca9510ff4e5d842c0589110243d60927836222 >> >> squashed together into one.] > > Why did you do that?
Because I thought it was better not to repeat the same mistakes that we did in mainline.. That is, in mainline, we did something like: patch 1 : fixed something but introduced a new bug patch 2 : fixed bug introduced by patch 1 So I thought it was better to reduce the noise and just do the right fix by squashing those 2 patches. IOW, replaying those patches faithfully and repeating the same mistakes in stable seemed pretty pointless to me... > You just lost the authorship information from > those two patches. No, I didn't! I squashed the Signed-off-by's and the Reviewed-by's etc too, so no authorship info was lost :-) (But I don't know if that is the right thing to do) > Please keep them separate and provide backported > versions (possibly not the whole thing, but the relevant parts). > Everything is relevant, but just that we don't really need 4 patches to do it.. Just 2 correct patches will do. Please consider my above thoughts and if you still want me to provide all the 4 patches, let me know and I'll do it. Regards, Srivatsa S. Bhat -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
