On Sat, Feb 25, 2012 at 12:06:31AM +0530, Srivatsa S. Bhat wrote: > On 02/24/2012 04:41 AM, Greg KH wrote: > > > On Thu, Feb 16, 2012 at 02:27:33PM +0530, Srivatsa S. Bhat wrote: > >> [ Upstream commits: > >> > >> a144c6a6c924aa1da04dd77fb84b89927354fdff > >> caca9510ff4e5d842c0589110243d60927836222 > >> > >> squashed together into one.] > > > > Why did you do that? > > > Because I thought it was better not to repeat the same mistakes that > we did in mainline.. That is, in mainline, we did something like: > patch 1 : fixed something but introduced a new bug > patch 2 : fixed bug introduced by patch 1 > > So I thought it was better to reduce the noise and just do the right > fix by squashing those 2 patches. IOW, replaying those patches > faithfully and repeating the same mistakes in stable seemed pretty > pointless to me... > > > You just lost the authorship information from > > > those two patches. > > > No, I didn't! I squashed the Signed-off-by's and the Reviewed-by's etc > too, so no authorship info was lost :-) > (But I don't know if that is the right thing to do)
The author of the original patches was lost when you did this. If I were to apply this patch as-is, it would show up in git that you wrote these patches, not the original authors. I prefer to duplicate the upstream patches, where ever possible, warts and all. That makes tracking problems, and fixing them, much easier over time. So please, resend these as the individual files, which preserves authorship information correctly, and I will be glad to review them for acceptance. greg k-h -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
