On Thu, May 3, 2012 at 2:02 PM, Greg KH <[email protected]> wrote: > On Thu, May 03, 2012 at 01:54:48PM -0600, Shuah Khan wrote: >> On Thu, May 3, 2012 at 1:39 PM, Andrew Morton <[email protected]> >> wrote: >> > On Thu, 3 May 2012 11:34:21 -0700 >> > Greg KH <[email protected]> wrote: >> > >> >> On Thu, May 03, 2012 at 12:19:16PM -0600, Shuah Khan wrote: >> >> > Sorry, forgot to Cc stable when the patch was sent to lkml >> >> > >> >> > >> >> > This patch adds a new field to led_classdev to save activattion state >> >> > after activate routine is successful. This saved state is used in >> >> > deactivate routine to do cleanup such as removing device files, and >> >> > free memory allocated during activation. Currently trigger_data not >> >> > being >> >> > null is used for this purpose. >> >> > >> >> > Existing triggers will need changes to use this new field. >> >> > >> >> > >From 3765101a5ffe32edd68a71bafca2d6d262cf2399 Mon Sep 17 00:00:00 2001 >> >> >> >> What commit id is that for? >> >> >> >> > From: Shuah Khan <[email protected]> >> >> > Date: Thu, 19 Apr 2012 20:44:15 -0600 >> >> > Subject: [PATCH 1/4] leds: add new field to led_classdev struct to save >> >> > activation state >> >> > >> >> >> >> I don't see this in Linus's tree, so what am I able to do with this? >> >> >> > >> > I have them queued for 3.5. I didn't schule them for 3.4 or -stable >> > because I was given no reason to do so, nor did I see a reason myself. >> > >> > Shuah, we only add bugfixes to -stable trees. I don't think this >> > patchset qualifies? >> > >> >> Andrew, >> >> Yes, this patch set definitely doesn't qualify under the bug fix >> category, however my hope is that, if it gets into stable kernels >> distros are picking up, maybe there is no need for staging area >> drivers such as timed-gpio and timed-output to be maintained. > > Please read Documentation/stable_kernel_rules.txt for what is and is not > acceptable for stable kernel releases. It's quite clear that "new > features" is not acceptable, don't you agree? > >
I can't argue with that. :) I am hoping since this feature is a standalone feature that would benefit community at large and might be a low risk to take. That said I am not going insist that you pick this patch set. -- Shuah -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
