On 5/10/2012 9:34 AM, Greg KH wrote:
> On Wed, May 09, 2012 at 06:14:44PM -0700, Asai Thambi S P wrote:
>> Hi,
>>
>> Below is the list of 'mtip32xx' patches in kernel 3.4. Please apply the same
>> to stable kernel 3.3.x. Let me know if you have any queries. Thanks.
>>
>> #. Commit ids : Description
>> -----------------------------------------------------------------------------
>> 1. 22be2e6e13ac09b20000582ac34d47fb0029a6da : fix incorrect value set for
>> drv_cleanup_done, and re-initialize and start port in mtip_restart_port()
>> 2. 6d27f09a6398ee086b11804aa3a16609876f0c7c : fix error handling in
>> mtip_init()
>
> These two are fine.
Thanks.
>
>> 3. 45038367c271f83b649b16551bf2d8174b203cb9 : Add new bitwise flag 'dd_flag'
>
> How does this fit the rules specified in
> Documentation/stable_kernel_rules.txt? I don't think it does, do you?
This is consolidation of flag variables into a single bitwise flag variable,
and defining new flags (using available bits in the bitmap).
Not required.
>
>> 4. dad40f16ff683a10f4f2bea55a0b9fd86d3db58e : make setting comp_time as
>> common
>
> Same here, what does this fix?
Not required.
>
>> 5. f65872177d838a33e90cbae25625b9bec05134ca : Add new sysfs entry 'status'
>
> That looks like a new feature, which isn't allowed in stable trees,
> right?
Not required.
>
>> 6. 8182b495281764ca518781e876c91900e75088d2 : misc changes
>
> Are these bugfixes?
Yes. Some parts depend on above patches. Apply only the following:
* Free ida index in remove path
hunks:
@@ -3657,6 +3669,11 @@ static int mtip_block_remove(struct driver_data *dd)
@@ -3686,6 +3703,11 @@ static int mtip_block_shutdown(struct driver_data *dd)
>
>> 7. 8a857a880bd83ba4f217d55dd4a623a7e4b5cb47 : Shorten macro names
>
> What?
Not required.
>
>> 8. c74b0f586fa3cbc92ca451836fd75ae7a3fa85ac : fix handling of commands in
>> various scenarios
>
> This almost looks ok, but it's quite big, don't you think?
Some parts depend on above patches. I can prepare a custom patch for the
following. Let me know if these items are ok.
* If a ncq command time out and a non-ncq command is active, skip restart port
* When a non-ncq command is active, allow incoming non-ncq commands to wait
instead of failing back
* Changed timeout for download microcode and smart commands
>
>> 9. 95fea2f1d90626498e2495a81fe5aab7fba9fb3f : dump tagmap on failure
>
> Why do we need this?
Code prints the individual tag of failed commands, instead this change prints
the tagmap.
Not required
>
>> 10. 63634806519b49bb43f37e53a1e8366eb3e846a4 : remove HOTPLUG_PCI_PCIE
>> dependancy
>
> I like this one, I took it :)
:)
>
>> Going forward, I will CC '[email protected]' in my patch emails.
>
> Please follow the stable_kernel_rules.txt rules when you do so,
> otherwise you waste everyone's time...
Sure.
--
Regards,
Asai Thambi
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
