On Thu, May 10, 2012 at 06:49:08PM -0700, Asai Thambi S P wrote: > On 5/10/2012 9:34 AM, Greg KH wrote: > > > On Wed, May 09, 2012 at 06:14:44PM -0700, Asai Thambi S P wrote: > >> Hi, > >> > >> Below is the list of 'mtip32xx' patches in kernel 3.4. Please apply the > >> same to stable kernel 3.3.x. Let me know if you have any queries. Thanks. > >> > >> #. Commit ids : Description > >> ----------------------------------------------------------------------------- > >> 1. 22be2e6e13ac09b20000582ac34d47fb0029a6da : fix incorrect value set for > >> drv_cleanup_done, and re-initialize and start port in mtip_restart_port() > >> 2. 6d27f09a6398ee086b11804aa3a16609876f0c7c : fix error handling in > >> mtip_init() > > > > These two are fine. > > > Thanks. > > > > >> 3. 45038367c271f83b649b16551bf2d8174b203cb9 : Add new bitwise flag > >> 'dd_flag' > > > > How does this fit the rules specified in > > Documentation/stable_kernel_rules.txt? I don't think it does, do you? > > > This is consolidation of flag variables into a single bitwise flag > variable, and defining new flags (using available bits in the bitmap). > > Not required.
Then why did you ask for these, and other patches that are not required, to be applied? > >> 4. dad40f16ff683a10f4f2bea55a0b9fd86d3db58e : make setting comp_time as > >> common > > > > Same here, what does this fix? > > > Not required. > > > > >> 5. f65872177d838a33e90cbae25625b9bec05134ca : Add new sysfs entry 'status' > > > > That looks like a new feature, which isn't allowed in stable trees, > > right? > > > Not required. > > > > >> 6. 8182b495281764ca518781e876c91900e75088d2 : misc changes > > > > Are these bugfixes? > > > Yes. Some parts depend on above patches. Apply only the following: > * Free ida index in remove path > > hunks: > @@ -3657,6 +3669,11 @@ static int mtip_block_remove(struct driver_data *dd) > @@ -3686,6 +3703,11 @@ static int mtip_block_shutdown(struct driver_data *dd) > > > > >> 7. 8a857a880bd83ba4f217d55dd4a623a7e4b5cb47 : Shorten macro names > > > > What? > > > Not required. > > > > >> 8. c74b0f586fa3cbc92ca451836fd75ae7a3fa85ac : fix handling of commands in > >> various scenarios > > > > This almost looks ok, but it's quite big, don't you think? > > > Some parts depend on above patches. I can prepare a custom patch for the > following. Let me know if these items are ok. > * If a ncq command time out and a non-ncq command is active, skip restart > port > * When a non-ncq command is active, allow incoming non-ncq commands to wait > instead of failing back > * Changed timeout for download microcode and smart commands Anyway, now that 3.4 is out, and 3.3 is about to go end-of-life, I'd not recommend doing this as it shouldn't be needed. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
