On Wed, 2012-10-03 at 15:40 +0200, Jiri Kosina wrote:
> [ commit 86e6b77eb7 upstream ]
> 
> From: Kevin Daughtridge <[email protected]>
> Subject: [PATCH] HID: keep dev_rdesc unmodified and use it for comparisons
> 
> The dev_rdesc member of the hid_device structure is meant to store the 
> original
> report descriptor received from the device, but it is currently passed to any
> report_fixup method before it is copied to the rdesc member. This patch uses a
> temporary buffer to shield dev_rdesc from the side effects of many HID 
> drivers'
> report_fixup implementations.
> 
> usbhid's hid_post_reset checks the report descriptor currently returned by the
> device against a descriptor that may have been modified by a driver's
> report_fixup method. That leaves some devices nonfunctional after a resume, 
> with
> a "reset_resume error 1" reported. This patch checks the new descriptor 
> against
> the unmodified dev_rdesc instead and uses the original, instead of modified,
> report size.
[...]

I'm assuming this isn't needed for 3.2, as usbhid's hid_post_reset()
doesn't appear to do anything like this.

Ben.

-- 
Ben Hutchings
You can't have everything.  Where would you put it?

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to