On Sun, Oct 07, 2012 at 03:17:33PM +0100, Ben Hutchings wrote:
> On Wed, 2012-10-03 at 15:40 +0200, Jiri Kosina wrote:
> > [ commit 86e6b77eb7 upstream ]
> > 
> > From: Kevin Daughtridge <[email protected]>
> > Subject: [PATCH] HID: keep dev_rdesc unmodified and use it for comparisons
> > 
> > The dev_rdesc member of the hid_device structure is meant to store the 
> > original
> > report descriptor received from the device, but it is currently passed to 
> > any
> > report_fixup method before it is copied to the rdesc member. This patch 
> > uses a
> > temporary buffer to shield dev_rdesc from the side effects of many HID 
> > drivers'
> > report_fixup implementations.
> > 
> > usbhid's hid_post_reset checks the report descriptor currently returned by 
> > the
> > device against a descriptor that may have been modified by a driver's
> > report_fixup method. That leaves some devices nonfunctional after a resume, 
> > with
> > a "reset_resume error 1" reported. This patch checks the new descriptor 
> > against
> > the unmodified dev_rdesc instead and uses the original, instead of modified,
> > report size.
> [...]
> 
> I'm assuming this isn't needed for 3.2, as usbhid's hid_post_reset()
> doesn't appear to do anything like this.

I believe that is correct.

josh
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to