commit: ae428655b826f2755a8101b27beda42a275ef8ad From: Nickolai Zeldovich <[email protected]> Date: Sat, 5 Jan 2013 14:17:45 -0500 Subject: staging: speakup: avoid out-of-range access in synth_init()
Check that array index is in-bounds before accessing the synths[] array. Signed-off-by: Nickolai Zeldovich <[email protected]> Cc: stable <[email protected]> Cc: Samuel Thibault <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> --- drivers/staging/speakup/synth.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c index df95337..b91d22b 100644 --- a/drivers/staging/speakup/synth.c +++ b/drivers/staging/speakup/synth.c @@ -342,7 +342,7 @@ int synth_init(char *synth_name) mutex_lock(&spk_mutex); /* First, check if we already have it loaded. */ - for (i = 0; synths[i] != NULL && i < MAXSYNTHS; i++) + for (i = 0; i < MAXSYNTHS && synths[i] != NULL; i++) if (strcmp(synths[i]->name, synth_name) == 0) synth = synths[i]; -- 1.7.3.4 -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
