commit: 6102c48bd421074a33e102f2ebda3724e8d275f9 From: Samuel Thibault <[email protected]> Date: Mon, 7 Jan 2013 22:03:51 +0100 Subject: staging: speakup: avoid out-of-range access in synth_add()
Check that array index is in-bounds before accessing the synths[] array. Signed-off-by: Samuel Thibault <[email protected]> Cc: stable <[email protected]> Cc: Nickolai Zeldovich <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> --- drivers/staging/speakup/synth.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c index b91d22b..7616f05 100644 --- a/drivers/staging/speakup/synth.c +++ b/drivers/staging/speakup/synth.c @@ -423,7 +423,7 @@ int synth_add(struct spk_synth *in_synth) int i; int status = 0; mutex_lock(&spk_mutex); - for (i = 0; synths[i] != NULL && i < MAXSYNTHS; i++) + for (i = 0; i < MAXSYNTHS && synths[i] != NULL; i++) /* synth_remove() is responsible for rotating the array down */ if (in_synth == synths[i]) { mutex_unlock(&spk_mutex); -- 1.7.3.4 -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
