* John Stultz <[email protected]> wrote:
> On 01/23/2014 01:17 AM, Ingo Molnar wrote:
> > * John Stultz <[email protected]> wrote:
> >
> >> Just wanted to send out a few timekeeping fixes that were merged
> >> in 3.14 which are appropriate for -stable.
> > No, they are not appropriate at all.
> >
> >> This queue backports the following fixes:
> >> -----------------------------------------
> >> f55c07607a38f84b5c7e6066ee1cfe433fa5643c timekeeping: Fix lost updates
> >> to tai adjustment
> >> 5258d3f25c76f6ab86e9333abf97a55a877d3870 timekeeping: Fix potential lost
> >> pv notification of time change
> >> 6fdda9a9c5db367130cf32df5d6618d08b89f46a timekeeping: Avoid possible
> >> deadlock from clock_was_set_delayed
> >> 04005f6011e3b504cd4d791d9769f7cb9a3b2eae timekeeping: Fix CLOCK_TAI
> >> timer/nanosleep delays
> >> 330a1617b0a6268d427aa5922c94d082b1d3e96d timekeeping: Fix missing
> >> timekeeping_update in suspend path
> >> d5a1c7e3fc38d9c7d629e1e47f32f863acbdec3d rtc-cmos: Add an alarm disable
> >> quirk
> > These patches should have had Cc: stable in them and should have gone
> > through timers/urgent!
>
> They did have Cc: stable in them.
But they did not go through timers/urgent, did they?
> [...]
>
> I'd argue these were non-urgent fixes that should still be
> backported to -stable.
No such thing exists really. Linus argued this repeatedly: if you
think it's not urgent enough for current -git then it's doubly not
urgent enough for -stable!
So my suggestion for the future: such fixes need to go to -git as
well, even if they seem difficult and late. Merging via the merge
window and then backporting is a generally harmful practice.
The fact that Greg is a soft hearted maintainer while Linus pushes
back strongly, in Finnish if needed, does not make this approach
right.
Anyway, it's water down the bridge, and I agree with you that the
-stable backport is probably justified in this particular case,
because the bugs fixed are serious enough: but it should be done after
-rc1 or -rc2, and we should also make sure this flow of commits does
not repeat in the future.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
