Hi John,

On Wed, Jan 22, 2014 at 05:34:53PM -0800, John Stultz wrote:
> Just wanted to send out a few timekeeping fixes that were merged
> in 3.14 which are appropriate for -stable.
> 
> This queue backports the following fixes:
> -----------------------------------------
> f55c07607a38f84b5c7e6066ee1cfe433fa5643c      timekeeping: Fix lost updates 
> to tai adjustment
> 5258d3f25c76f6ab86e9333abf97a55a877d3870      timekeeping: Fix potential lost 
> pv notification of time change
> 6fdda9a9c5db367130cf32df5d6618d08b89f46a      timekeeping: Avoid possible 
> deadlock from clock_was_set_delayed
> 04005f6011e3b504cd4d791d9769f7cb9a3b2eae      timekeeping: Fix CLOCK_TAI 
> timer/nanosleep delays
> 330a1617b0a6268d427aa5922c94d082b1d3e96d      timekeeping: Fix missing 
> timekeeping_update in suspend path
> d5a1c7e3fc38d9c7d629e1e47f32f863acbdec3d      rtc-cmos: Add an alarm disable 
> quirk

Two questions on these patches:

1) Should they be applied to 3.13 stable only?  At least some of them seem
to be applicable to older kernels as well.

2) Shouldn't 47a1b796 ("tick/timekeeping: Call update_wall_time outside
the jiffies lock") be applied as well?  There's a compilation warning
introduced by 6fdda9a:

  kernel/time/timekeeping.c:1446:6: warning: the address of 'clock_was_set' 
will always evaluate as 'true' [-Waddress]

that seems to be a bug, fixed by 47a1b796.

Cheers,
--
Luis

> I've run these through my timetest suite w/ kvm on arm, i386,
> & x86_64. But more testing would be of course appreciated.
>       https://github.com/johnstultz-work/timetests
> 
> I also have patch queues for -stable trees back to 3.4 that I'll be
> sending out as my testing completes for those trees.
> 
> Cc: Sasha Levin <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> Cc: Prarit Bhargava <[email protected]>
> Cc: Richard Cochran <[email protected]>
> Cc: Ingo Molnar <[email protected]>
> Cc: Borislav Petkov <[email protected]>
> Cc: David Vrabel <[email protected]>
> Cc: Konrad Rzeszutek Wilk <[email protected]>
> Cc: stable <[email protected]>
> 
> Borislav Petkov (1):
>   3.13.y: rtc-cmos: Add an alarm disable quirk
> 
> John Stultz (5):
>   3.13.y: timekeeping: Fix lost updates to tai adjustment
>   3.13.y: timekeeping: Fix potential lost pv notification of time change
>   3.13-stable: timekeeping: Avoid possible deadlock from
>     clock_was_set_delayed
>   3.13.y: timekeeping: Fix CLOCK_TAI timer/nanosleep delays
>   3.13.y: timekeeping: Fix missing timekeeping_update in suspend path
> 
>  drivers/rtc/rtc-cmos.c    | 52 
> ++++++++++++++++++++++++++++++++++++++++++++++-
>  kernel/time/timekeeping.c | 47 +++++++++++++++++++++++++++++-------------
>  2 files changed, 84 insertions(+), 15 deletions(-)
> 
> -- 
> 1.8.3.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to [email protected]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to