2011/2/9 Rupert Westenthaler <[email protected]>: > On Wed, Feb 9, 2011 at 6:54 PM, Olivier Grisel <[email protected]> > wrote: >> Actually I made a mistake: the package names are already in lowercase. > That actually true. However I have to admit that there are still some > package names with upper case letter (e.g. [1]) that need to be > changed. > >> However the project folders are not but I think it would be better if >> they were consistent with package names. Eg: >> >> entityhub/yard/embeddedSolrProvider => >> entityhub/yard/embeddedsolr >> >> and >> >> entityhub/yard/solrProvider = > entityhub/yard/solr > > > The fact that "entityhub/yard/solr" is already the name used for the > module of the SolrYard was the reason why I called it solrProvider. > Initially I have not liked the idea to put this two modules within > "entityhub/yard" because they do not represent an Yard implementation > but I could also not come up with a better fitting location and so I > decided to give them rather long but clear names. > > WDYT of using "." notation to mark "helper" modules > entityhub/yard/solr -> The SolrYard > entityhub/yard/solr.provider -> Solr provider > entityhub/yard/solr.embedded -> EmbeddedSolrServer
We should definitely avoid dots "." in folder names. It makes it confuses IDEs a lot when dealing with relative java package names. I would prefer "solrprovider" and "embeddedsolrprovider". Alternatively we can put both providers into the solr yard folder. No need for subpackages: can just use the OSGi configuration to switch from one provider impl to another. -- Olivier http://twitter.com/ogrisel - http://github.com/ogrisel
