Hi Wiktor, * Wiktor Kwapisiewicz <[email protected]> [2019-02-04 23:00]: > I did a quick "git grep" but it seems XEPs do not use any stylistic WARNING > messages so I added a paragraph: > > https://github.com/xsf/xeps/pull/743/files#diff-4fd958d9730d81a5ba1b395dba37039bR239
+1 (formally, now) Thanks very much! The wording is appropriate in my eyes. Just some minor remarks that don't influence my formal vote: - please move the warning paragraph above the example, not below it. This increases the chance of people reading it before copy&passting things into config files - in the first paragraph, it should be "CORS headers" and not "CORS-Headers" - You could use a <p class="box"> to highlight the warning (example in https://xmpp.org/extensions/xep-0390.html#algorithm-input) but I'd rather suggest using a box for a two-sentence explanation of the special meaning of "Access-Control-Allow-Origin: *" @Dave: in my eyes, the problem is not with the "*" but with accidentally setting the header for your whole domain / application, and thus breaking things. Georg -- || http://op-co.de ++ GCS d--(++) s: a C+++ UL+++ !P L+++ !E W+++ N ++ || gpg: 0x962FD2DE || o? K- w---() O M V? PS+ PE-- Y++ PGP+ t+ 5 R+ || || Ge0rG: euIRCnet || X(+++) tv+ b+(++) DI+++ D- G e++++ h- r++ y? || ++ IRCnet OFTC OPN ||_________________________________________________||
signature.asc
Description: PGP signature
_______________________________________________ Standards mailing list Info: https://mail.jabber.org/mailman/listinfo/standards Unsubscribe: [email protected] _______________________________________________
