Hello, On 05.02.2019 10:28, Georg Lukas wrote:
+1 (formally, now)
Thank you!
Thanks very much! The wording is appropriate in my eyes. Just some minor remarks that don't influence my formal vote: - please move the warning paragraph above the example, not below it. This increases the chance of people reading it before copy&passting things into config files - in the first paragraph, it should be "CORS headers" and not "CORS-Headers"
I've fixed these two.
- You could use a <p class="box"> to highlight the warning (example in https://xmpp.org/extensions/xep-0390.html#algorithm-input) but I'd rather suggest using a box for a two-sentence explanation of the special meaning of "Access-Control-Allow-Origin: *"
Hmm... did I get this right that I should add a <p class="box"> paragraph with the explanation of "Access-Control-Allow-Origin: *" inside the XEP? Would that be placed below the example? (just double checking)
Kind regards, Wiktor -- https://metacode.biz/@wiktor
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Standards mailing list Info: https://mail.jabber.org/mailman/listinfo/standards Unsubscribe: [email protected] _______________________________________________
