On Wed, 30 Dec 2020, 16:33 JC Brand, <li...@opkode.com> wrote:

>
>
> On 18.12.20 19:10, Dave Cridland wrote:
> > On Fri, 18 Dec 2020 at 17:01, JC Brand <li...@opkode.com
> > <mailto:li...@opkode.com>> wrote:
> >
> > Hi all
> >
> > I've submitted a PR for a new protoXEP: MUC Mention Notifictions
> >
> > https://github.com/xsf/xeps/pull/1022
> > <https://github.com/xsf/xeps/pull/1022>
> >
> >
> > Thanks, this looks like a solid start and I will be voting to accept it.
>
> Thanks, your cheque is in the mail.
>

For the avoidance of doubt, I would never accept a cheque for a vote. Who
on earth accepts cheques these days?


> > Comments:
> >
> > 1) I think it would benefit from an example of the mention itself,
> > though I assume it to be the message shown as forwarded in §3.2
>
> Yeah, it would just be a copy paste of the inner <message>. I've added
> some clarifying text to the bottom of the example.
>

Thanks.


> > 2) Section 3.2 shows a message being forwarded to a full jid for the
> > mentioned user - is this intentional?
>
> Nope, fixed thanks.
>

Thanks.


> > 3) The message forwarded doesn't contain, and is not accompanied by, a
> > MAM stanza-id, which might be useful to locate it in the MUC archive.
> > Can we include this if the room is archived?
>
> Ok, I added it.
>
> I was wondering whether I should include the stanza-id or not and
> originally decided not to in order to keep the stanza clear and to the
> point of this particular XEP.
>

If I get a mention in a room I'm in, it's useful to immediately scroll to
find the context. Otherwise, a "I don't know, ask dwd" isn't very useful.

A MAM id would let me do this, or at least enable that UX, so I think it's
important to include, and indeed mandate.



> Thanks
> JC
>
> _______________________________________________
> Standards mailing list
> Info: https://mail.jabber.org/mailman/listinfo/standards
> Unsubscribe: standards-unsubscr...@xmpp.org
> _______________________________________________
>
_______________________________________________
Standards mailing list
Info: https://mail.jabber.org/mailman/listinfo/standards
Unsubscribe: standards-unsubscr...@xmpp.org
_______________________________________________

Reply via email to